Remember a user's filter preferences when they return to the site #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great! We could possibly base64 encode this in the URL and store in the hash. That way you could share the filters with friends! |
hauxir
reviewed
Aug 5, 2021
| minTomatoMeter, | ||
| minAudience, | ||
| genres, | ||
| networks |
There was a problem hiding this comment.
Order the keys, or order the value array?
There was a problem hiding this comment.
i mean the adding the ordering of the data in the table :)
There was a problem hiding this comment.
Oh! Yes, I can do that.
As for storing this in the URL, I can see about encoding this stuff with query params so the values are easily visible when sharing.
|
Is this moving along? The project is very handy and this would be a nice feature |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remember a user's filters when they come back to the site.
Plus a few indentation fixes.