Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add xhr2 package #339

Closed
wants to merge 3 commits into from
Closed

Conversation

im-adithya
Copy link

This should fix the error described in haveno-dex/haveno#1482.

To use:
npm install
npm pack

and install the packaged file in sample app
npm install haveno-ts-0.0.30.tgz
npm run start

You will not see the XMLHttpRequest is not defined error anymore

@woodser
Copy link
Contributor

woodser commented Dec 29, 2024

Thanks for your submission. In the end, this solution provided everything we were looking for: #338

  • Uses node-xmlhttprequest which is currently used in the jest tests
  • Only imports types to the global object if not present
  • Exports the types for clients to use without additional imports
  • Ignores type warnings
  • Doesn't introduce vulnerabilities (actually fixes the current high severity vulnerability).

@woodser woodser closed this Dec 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants