Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Operation add datasource and remove datasource fails if running on th… #186

Merged
merged 2 commits into from
Feb 16, 2017

Conversation

josejulio
Copy link
Member

…e newest hawkular-services container

We now detect (currently via env variable) if we are running in one and expects those tests to fail.

…e newest hawkular-services container

We now detect (currently via env variable) if we are running in one and expects those tests to fail.
@josejulio josejulio force-pushed the operations-running-in-container branch from a44267e to 57817a2 Compare February 10, 2017 16:30
@coveralls
Copy link

coveralls commented Feb 10, 2017

Coverage Status

Coverage increased (+0.004%) to 96.15% when pulling 57817a2 on josejulio:operations-running-in-container into 5873ed6 on hawkular:master.

@josejulio
Copy link
Member Author

I'll try to get the server immutable flag instead of setting a value.

@josejulio josejulio force-pushed the operations-running-in-container branch from c63125a to 546fd7b Compare February 14, 2017 18:18
@coveralls
Copy link

coveralls commented Feb 14, 2017

Coverage Status

Coverage increased (+0.1%) to 96.294% when pulling 546fd7b on josejulio:operations-running-in-container into 5873ed6 on hawkular:master.

@josejulio
Copy link
Member Author

@pilhuhn This tries to fetch the "In Container" property from the agent to determine how to behave on a couple of operation specs. If said property isn't found, we default to "In Container" = false.

@pilhuhn
Copy link
Member

pilhuhn commented Feb 16, 2017

I'll merge that now. In-Container flag will be provided for container builds once https://github.com/hawkular/hawkular-services/pull/122 is merged.

@pilhuhn pilhuhn merged commit 7c4cf65 into hawkular:master Feb 16, 2017
@josejulio
Copy link
Member Author

There seems to be new errors there, I'll check it and follow this up.

@rubenvp8510 rubenvp8510 modified the milestone: 2.9.0 Mar 1, 2017
@josejulio josejulio deleted the operations-running-in-container branch November 30, 2017 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants