Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

style(maitake): fix dead code warnings with loom #188

Merged
merged 2 commits into from
Jun 3, 2022
Merged

style(maitake): fix dead code warnings with loom #188

merged 2 commits into from
Jun 3, 2022

Conversation

hawkw
Copy link
Owner

@hawkw hawkw commented Jun 3, 2022

Signed-off-by: Eliza Weisman eliza@buoyant.io

@hawkw
style(maitake): fix dead code warnings with loom
1d326d3 
Signed-off-by: Eliza Weisman <eliza@buoyant.io>
@hawkw hawkw enabled auto-merge (squash) June 3, 2022 17:03
hawkw added a commit that referenced this pull request Jun 3, 2022
@hawkw
feat(maitake): addClone/Drop for TaskRef
1a72fd0 
these increment/decrement the task's reference count and can drop the
task if the dropped `TaskRef` is the last ref.

Will be needed for #184

Depends on #188

Signed-off-by: Eliza Weisman <eliza@buoyant.io>
hawkw added a commit that referenced this pull request Jun 3, 2022
@hawkw
feat(maitake): addClone/Drop for TaskRef
4d8a1a7 
these increment/decrement the task's reference count and can drop the
task if the dropped `TaskRef` is the last ref.

Will be needed for #184

Depends on #188

Signed-off-by: Eliza Weisman <eliza@buoyant.io>
@hawkw hawkw mentioned this pull request Jun 3, 2022
Merged
@hawkw hawkw merged commit 0029a1b into main Jun 3, 2022
@hawkw hawkw deleted the eliza/loom-warnings branch June 3, 2022 17:12
hawkw added a commit that referenced this pull request Jun 3, 2022
@hawkw
feat(maitake): addClone/Drop for TaskRef
20332d9 
these increment/decrement the task's reference count and can drop the
task if the dropped `TaskRef` is the last ref.

Will be needed for #184

Depends on #188

Signed-off-by: Eliza Weisman <eliza@buoyant.io>
hawkw added a commit that referenced this pull request Jun 3, 2022
@hawkw
feat(maitake): addClone/Drop for TaskRef (#189)
bde8172 
these increment/decrement the task's reference count and can drop the
task if the dropped `TaskRef` is the last ref. this required some changes
to reference counting via poll state transitions.

will be needed for #184
depends on #188

Signed-off-by: Eliza Weisman <eliza@buoyant.io>
@hawkw hawkw mentioned this pull request Jan 1, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@hawkw