Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrades hawtio/react to 0.9.2 #199

Merged
merged 4 commits into from
Nov 21, 2023
Merged

Upgrades hawtio/react to 0.9.2 #199

merged 4 commits into from
Nov 21, 2023

Conversation

phantomjinx
Copy link
Member

@phantomjinx phantomjinx commented Nov 17, 2023 •
edited
Loading

@phantomjinx phantomjinx requested a review from tadayosi November 17, 2023 16:33
@phantomjinx phantomjinx self-assigned this Nov 17, 2023
@phantomjinx phantomjinx mentioned this pull request Nov 17, 2023
Closed
@phantomjinx
Copy link
Member Author

This PR will need to have #198 be merged then it will need to be rebased in order for the tests to pass. The fix for resolving webpack node_modules directories is required from #198.

@phantomjinx phantomjinx force-pushed the upgrade-hawtio-react-0.9.2 branch 2 times, most recently from 7d27a2f to 31829ef Compare November 20, 2023 14:06
@phantomjinx
fix: Updates test apps login form now that useUser is available
df19492 
* useUser hook exported from hawtio/react so can fix the login process
  when using form-login mode in the test apps

* Test login pages need to wait from the userService to complete before
  trying to load the login form

* Logic based entirely on the hawtio/next login form
@phantomjinx phantomjinx force-pushed the upgrade-hawtio-react-0.9.2 branch from 31829ef to df19492 Compare November 20, 2023 14:09
@phantomjinx
chore: Corrects naming of test app components
42129d8 
* Components should have UpperCamelCase.
@phantomjinx
fix: Replaces manual fetchUser with useUser hook
732e52a 
* Now that the hook is exported.
@phantomjinx phantomjinx force-pushed the upgrade-hawtio-react-0.9.2 branch from bbdaaef to 732e52a Compare November 20, 2023 16:00
tadayosi
tadayosi approved these changes Nov 21, 2023
View reviewed changes
Copy link
Member

@tadayosi tadayosi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now.

@tadayosi tadayosi merged commit 619b3df into hawtio:main Nov 21, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tadayosi tadayosi tadayosi approved these changes

Assignees

@phantomjinx phantomjinx

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@phantomjinx @tadayosi