Adds other commands to deploy install Makefile #245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* deploy/Makefile * Adds generate-proxying, generate-serving & authclient as rules and includes them in the install * Moves bash scripts to deploy/script and soft-links to them from root scripts directory to preserve working commands in yarn package.json * generate-serving.sh * Updates script to include check for kube binary and the namespace for the secret
tadayosi
approved these changes
Dec 7, 2023
Yes. I wanted to ensure current usability is maintained, especially as not sure when / if we might change over to promoting the use of the deploy/Makefile in the README rather than |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
deploy/Makefile
Adds generate-proxying, generate-serving & authclient as rules and includes them in the install
Moves bash scripts to deploy/script and soft-links to them from root scripts directory to preserve working commands in yarn package.json
generate-serving.sh
Updates script to include check for kube binary and the namespace for the secret