Fixes to dev server configuration #292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phantomjinx
force-pushed
the
dev-server-fixes
branch
from
64d5998 to
94f0140
Compare
|
Tested with CRC and works as expected. |
* 'plugin' does not exist
* Cannot get the basepath to be respected by the devServer when trying to redirect to the form /login address. Just cannot find the exact recipe for configuring the devServer to correctly passthrough the /login to the app * Keeps the /online basepath for the production compilation
* The oauthclient script looks for the installed openshift route so must be installed after the deployment has been applied
phantomjinx
force-pushed
the
dev-server-fixes
branch
from
94f0140 to
bc047c8
Compare
tadayosi
approved these changes
Jan 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Talking with @mmelko, it became apparent that the original commit that added the
/onlineprefix to thedevServeronly seemed to half-work and failed entirely to find the/loginpage when the environment was configured forformmode. So this reverts that setup but keep/onlineas the prefix when the project is built for installation.Encountered an error when testing on OpenShift that had the
authclient.shscript being executed too soon.