fix: Split Discover to only display if no current connection (#188) #549
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
) * Splits the Discover plugin into 2: * Discover Core: preferences and header menu (always active) * Discover: page dashboad component (only active if no current connection) * discover-core * Moves preferences to this plugin * Moves header menu to this plugin * Adds as a new plugin, always active * By not including a plugin-path, the plugin will not be listed in the nav sidebar * discover * Dashboard only active if the connect-server does not contain a current connection
tadayosi
approved these changes
Oct 16, 2024
oscerd
approved these changes
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Splits the Discover plugin into 2:
discover-core
discover