This repository has been archived by the owner on Jun 12, 2024. It is now read-only.
Added currencies XAG and XAU to currency.ts #535
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I added XAG and XAU for myself and others who prefer to measure value with something of substance. Review the ISO 4217 standard to view a full list of official currency codes including the ones I have added. https://www.iso.org/iso-4217-currency-codes.html https://en.wikipedia.org/wiki/ISO_4217 Example: https://www.xe.com/currencyconverter/convert/?Amount=100&From=XAG&To=USD API for exchange rates: https://openexchangerates.org/
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
|
I'm the only one who can do that. Idk why you're taking other people here. |
OK. I was not aware. Thank you! |
|
@hay-kot Would you review this pull? I think it is all set now. |
hay-kot
pushed a commit
that referenced
this pull request
Jan 28, 2024
* Added currencies XAG and XAU to currency.ts I added XAG and XAU for myself and others who prefer to measure value with something of substance. Review the ISO 4217 standard to view a full list of official currency codes including the ones I have added. https://www.iso.org/iso-4217-currency-codes.html https://en.wikipedia.org/wiki/ISO_4217 Example: https://www.xe.com/currencyconverter/convert/?Amount=100&From=XAG&To=USD API for exchange rates: https://openexchangerates.org/ * Added field values xag and xau to group.go * Update group.go Former-commit-id: 5438898
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have added the currencies XAG and XAU for those who wish to measure value with something of substance.
Review the ISO 4217 standard to view a full list of official currency codes including the ones I have added.
https://www.iso.org/iso-4217-currency-codes.html
https://en.wikipedia.org/wiki/ISO_4217
Example:
https://www.xe.com/currencyconverter/convert/?Amount=100&From=XAG&To=USD
API for exchange rates:
https://openexchangerates.org/
What type of PR is this?
What this PR does / why we need it:
Adds two currencies to homebox.
We need this feature to serve those who wish to value their inventory with these currencies.
Which issue(s) this PR fixes:
This fixes the lack of currencies.
Special notes for your reviewer:
Does it function as expected?
Testing
I have not tested it.
Release Notes
Added currencies XAG and XAU.