Skip to content
This repository was archived by the owner on Jan 13, 2025. It is now read-only.

Use remote schema for Prometheus rule #7

Merged
merged 1 commit into from
Nov 18, 2023
Merged

Conversation

hayk96
Copy link
Owner

@hayk96 hayk96 commented Nov 18, 2023

1. What this PR does / why we need it:

  • Replacing the schema validation mechanism. Since the SchemaStore has a valid schema for the Prometheus rules, this approach will allow us to have an up-to-date schema. It will eliminate the need for additional maintenance in this app to keep the Rule schema up to date

2. Make sure that you've checked the boxes below before you submit PR:

  • DCO signed
  • No conflict with the main branch.

@hayk96 hayk96 self-assigned this Nov 18, 2023
@hayk96 hayk96 added the enhancement New feature or request label Nov 18, 2023
Signed-off-by: hayk96 <hayko5999@gmail.com>
@hayk96 hayk96 force-pushed the prometheus-rule-schema branch from d4eca77 to 8f4e986 Compare November 18, 2023 22:02
@hayk96 hayk96 changed the title Use remote chema for Prometheus rule Use remote schema for Prometheus rule Nov 18, 2023
@hayk96 hayk96 merged commit 8d69d15 into main Nov 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant