Change the log level and the message when ECS client cannot resolve public IPs. #220
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per discussion on #218 (comment), ECS client logs a warn when public IPs are not fetched. Also from the previous comment of Rafal:
"It should not crash the whole Hazelcast" - It already does not.
"It should not print retry logs (at the INFO level)" - Retry logs are always printed at fine level:
hazelcast-aws/src/main/java/com/hazelcast/aws/RetryUtils.java
Lines 57 to 58 in e78d8c2
"It should only print a warning...We treat it as a correct configuration" - Changed with this PR and it behaves like that now.
This is not the case for EC2 as
describeInstance
permission already contains this public ip data.The PR also makes the behavior consistent with the Kubernetes one.