Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the log level and the message when ECS client cannot resolve public IPs. #220

Merged
merged 1 commit into from
Dec 29, 2020

Conversation

enozcan
Copy link
Contributor

@enozcan enozcan commented Dec 29, 2020

Per discussion on #218 (comment), ECS client logs a warn when public IPs are not fetched. Also from the previous comment of Rafal:

  • "It should not crash the whole Hazelcast" - It already does not.

  • "It should not print retry logs (at the INFO level)" - Retry logs are always printed at fine level:

    LOGGER.fine(String.format("Couldn't connect to the AWS service, [%s] retrying in %s seconds...",
    retryCount, waitIntervalMs / MS_IN_SECOND));

  • "It should only print a warning...We treat it as a correct configuration" - Changed with this PR and it behaves like that now.

This is not the case for EC2 as describeInstance permission already contains this public ip data.

The PR also makes the behavior consistent with the Kubernetes one.

Copy link

@leszko leszko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@enozcan enozcan merged commit 8199c00 into hazelcast:master Dec 29, 2020
@enozcan enozcan deleted the fix/public-ip-logs branch December 29, 2020 13:06
@enozcan enozcan changed the title Log warning when couldn't fetch public IPs. Change the log level and the message when ECS client cannot resolve public IPs. Dec 29, 2020
@mtyazici mtyazici added this to the 3.3.1 milestone Mar 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants