-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add PLACEMENT_AWARE partition group support. #221
Conversation
01fbbd4
to
55d59c0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added some comments. The code looks fine, most comments are actually to README.
Additionally, I think we should merge PR after hazelcast/hazelcast#18048
Co-authored-by: Rafał Leszko <rafal@hazelcast.com>
@leszko PTAL |
Per hazelcast/hazelcast#18048 (comment), replaced |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added 3 comments to README. Other than that, LGTM 👍
I noticed that with the current setup it keeps retrying even after 404 response is received. This causes instances to start after ~15 seconds of delay with 5 retry count - even an instance does not belong to a placement group. As the current rest client expects only HTTP_OK and assumes failed otherwise, the rest client needs some refactoring to overcome this. I added the required changes to this PR via 88849d7 but it might be difficult to review them all together here. I can separate this into two different PRs: 1) Rest client refactoring and 2) Placement Aware support. @leszko Please let me know your opinion and I'm sorry for the inconvenience. What 88849d7 does is:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added one minor comment. Other than that, looks good. Thanks @enozcan for the changes.
Co-authored-by: Rafał Leszko <rafal@hazelcast.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍 Thanks for the clean code.
Adds placement aware partition group strategy support to form partition groups based on AWS placement groups. The strategy provides availability within a single zone as high as possible by spreading partitions and their replicas across different racks.