Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change logResult to only log once #229

Merged
merged 2 commits into from
Mar 9, 2021
Merged

Change logResult to only log once #229

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ca8ddab
Change logResult to only log once
mtyazici Mar 4, 2021
5048762
Add a new boolean for repeating log check
mtyazici Mar 8, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/main/java/com/hazelcast/aws/AwsDiscoveryStrategy.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,7 @@ public class AwsDiscoveryStrategy
private final Map<String, String> memberMetadata = new HashMap<>();

private boolean isKnownExceptionAlreadyLogged;
private boolean isEmptyAddressListAlreadyLogged;

AwsDiscoveryStrategy(Map<String, Comparable> properties) {
super(LOGGER, properties);
Expand Down Expand Up @@ -208,9 +209,10 @@ public Iterable<DiscoveryNode> discoverNodes() {
return Collections.emptyList();
}

private static void logResult(Map<String, String> addresses) {
if (addresses.isEmpty()) {
private void logResult(Map<String, String> addresses) {
if (addresses.isEmpty() && !isEmptyAddressListAlreadyLogged) {
LOGGER.warning("No IP addresses found! Starting standalone.");
isEmptyAddressListAlreadyLogged = true;
}

LOGGER.fine(String.format("Found the following (private => public) addresses: %s", addresses));
Expand Down