Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add client version check to hot restart test for back compatibility #938

Merged
merged 3 commits into from
Jun 14, 2021
Merged

Add client version check to hot restart test for back compatibility #938

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2d30257
Add client version check to hot restart test for back compat
srknzl Jun 14, 2021
c0329b2
Add check to client destruction
srknzl Jun 14, 2021
e1c6343
Set client to undefined in beforeEach
srknzl Jun 14, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion test/integration/backward_compatible/ClientHotRestartEventTest.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,11 +53,14 @@ describe('ClientHotRestartEventTest', function () {
});

beforeEach(async function () {
client = undefined;
cluster = await RC.createClusterKeepClusterName(null, createClusterConfig(5701));
});
mdumandag marked this conversation as resolved.
Show resolved Hide resolved

afterEach(async function () {
await client.shutdown();
if (client) {
await client.shutdown();
}
await RC.terminateCluster(cluster.id);
});

Expand All @@ -82,6 +85,7 @@ describe('ClientHotRestartEventTest', function () {
});

it('should receive membership events when the member is restarted on same address', async function () {
TestUtil.markClientVersionAtLeast(this, '4.2');
srknzl marked this conversation as resolved.
Show resolved Hide resolved
const oldMember = await RC.startMember(cluster.id);

let memberAdded = false;
Expand Down