Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[API-282] Implement SQL service #390

Merged
merged 9 commits into from
Jun 14, 2021
Merged

[API-282] Implement SQL service #390

merged 9 commits into from
Jun 14, 2021

Conversation

mdumandag
Copy link
Contributor

@mdumandag mdumandag commented Apr 15, 2021

Added a new service called sql that executes SQL queries on
Maps.

The service returns a SqlResult immediately so that, the user
can cancel queries immediately.

Also, via SqlResult, the user can get blocking or non-blocking
iterators to get results row-by-row.

The rows contain row metadata along with the objects that can be
accessed either through the column names or column indexes.

The row metadata contains information about the columns returned
in rows.

Also, the users can get the update count, row metadata, and whether or
not the result contains rows through SqlResult.

Added a new service called `sql` that executes SQL queries on
Maps.

The service returns a `SqlResult` immediately so that, the user
can cancel queries immediately.

Also, via `SqlResult`, the user can get blocking or non-blocking
iterators to get results row-by-row.

The rows contain row metadata along with the objects that can be
accessed either through the column names or column indexes.

The row metadata contains information about the columns returned
in rows.

Also, the users can get the update count, row metadata, and whether or
not the result contains rows through `SqlResult`.
@mdumandag mdumandag changed the title [API-282] SQL Service Implementation [API-282] Implement SQL service May 6, 2021
@mdumandag mdumandag marked this pull request as ready for review May 6, 2021 15:07
@mdumandag
Copy link
Contributor Author

verify

@mdumandag
Copy link
Contributor Author

verify

@mdumandag
Copy link
Contributor Author

verify

hazelcast/sql.py Outdated
Comment on lines 63 to 65
``__key`` and ``this``, respectively. If key (or value) object has fields,
then the whole key (or value) field is exposed as a normal field. Otherwise the
field is hidden. Hidden fields can be accessed directly, but are not returned
Copy link
Member

@srknzl srknzl Jun 11, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the correct sentence is(as I told you in a message I sent to you):

If key (or value) object has fields, then the key (or value) field is hidden. Otherwise, the whole key (or value) field is exposed as a normal field.

I think we should change this sentence in other clients too

hazelcast/sql.py Outdated Show resolved Hide resolved
Copy link
Member

@srknzl srknzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving with minor comments. Some of them are in this pr some of them are in #406

@mdumandag mdumandag merged commit df2a1cb into hazelcast:master Jun 14, 2021
@mdumandag mdumandag deleted the sql branch June 14, 2021 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants