-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[API-282] Implement SQL service #390
Conversation
ef640ff
to
b3ad81f
Compare
Added a new service called `sql` that executes SQL queries on Maps. The service returns a `SqlResult` immediately so that, the user can cancel queries immediately. Also, via `SqlResult`, the user can get blocking or non-blocking iterators to get results row-by-row. The rows contain row metadata along with the objects that can be accessed either through the column names or column indexes. The row metadata contains information about the columns returned in rows. Also, the users can get the update count, row metadata, and whether or not the result contains rows through `SqlResult`.
verify |
verify |
verify |
hazelcast/sql.py
Outdated
``__key`` and ``this``, respectively. If key (or value) object has fields, | ||
then the whole key (or value) field is exposed as a normal field. Otherwise the | ||
field is hidden. Hidden fields can be accessed directly, but are not returned |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the correct sentence is(as I told you in a message I sent to you):
If key (or value) object has fields, then the key (or value) field is hidden. Otherwise, the whole key (or value) field is exposed as a normal field.
I think we should change this sentence in other clients too
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving with minor comments. Some of them are in this pr some of them are in #406
Added a new service called
sql
that executes SQL queries onMaps.
The service returns a
SqlResult
immediately so that, the usercan cancel queries immediately.
Also, via
SqlResult
, the user can get blocking or non-blockingiterators to get results row-by-row.
The rows contain row metadata along with the objects that can be
accessed either through the column names or column indexes.
The row metadata contains information about the columns returned
in rows.
Also, the users can get the update count, row metadata, and whether or
not the result contains rows through
SqlResult
.