[API-466] Fire membership events when HotRestart is enabled #412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdumandag
commented
Jun 11, 2021
mdumandag
force-pushed
the
hot-restart-memberlist-reset
branch
from
78c3ddd
to
3edf341
Compare
With this change, we now clear the memberlist when the cluster changes, instead of just clearing the memberlist version so that, we can fire events when a member with HotRestart enabled restarts with the same UUID. Added a test that verifies this behavior. Also, removed an unnecessary usage of the `clear_member_list_version` method.
mdumandag
force-pushed
the
hot-restart-memberlist-reset
branch
from
3edf341
to
7f2a42c
Compare
srknzl
reviewed
Jun 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this change, we now clear the memberlist when the cluster changes,
instead of just clearing the memberlist version so that, we can
fire events when a member with HotRestart enabled restarts with
the same UUID. Added a test that verifies this behavior.
Also, removed an unnecessary usage of the
clear_member_list_versionmethod.
closes #371