Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[API-466] Fire membership events when HotRestart is enabled #412

Merged
merged 1 commit into from
Jun 14, 2021

Conversation

mdumandag
Copy link
Contributor

With this change, we now clear the memberlist when the cluster changes,
instead of just clearing the memberlist version so that, we can
fire events when a member with HotRestart enabled restarts with
the same UUID. Added a test that verifies this behavior.

Also, removed an unnecessary usage of the clear_member_list_version
method.

closes #371

@mdumandag mdumandag added this to the 4.2 milestone Jun 11, 2021
@mdumandag mdumandag self-assigned this Jun 11, 2021
@mdumandag mdumandag force-pushed the hot-restart-memberlist-reset branch from 78c3ddd to 3edf341 Compare June 14, 2021 09:00
With this change, we now clear the memberlist when the cluster changes,
instead of just clearing the memberlist version so that, we can
fire events when a member with HotRestart enabled restarts with
the same UUID. Added a test that verifies this behavior.

Also, removed an unnecessary usage of the `clear_member_list_version`
method.
@mdumandag mdumandag force-pushed the hot-restart-memberlist-reset branch from 3edf341 to 7f2a42c Compare June 14, 2021 09:01
Copy link
Member

@srknzl srknzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[TRACKING ISSUE] Fire membership events when persistence enabled
2 participants