Follow-up aggregators implementation #445
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #445 +/- ##
==========================================
- Coverage 86.09% 85.95% -0.15%
==========================================
Files 340 340
Lines 17850 17915 +65
==========================================
+ Hits 15368 15398 +30
- Misses 2482 2517 +35
Continue to review full report at Codecov.
|
mdumandag
force-pushed
the
aggregator-followup
branch
from
92b7b99
to
f50ae5e
Compare
There were couple of missing things in the community PR for the aggregators. This is an attempt to fix those. Namely, - Some missing aggreagators are added (distinct, min_by, max_by). For them, some identified factories are also added, as they have different return values. - Aggregator module is added to the API documentation - A code sample is added - Docstrings are updated - Documentation is updated and corrected
mdumandag
force-pushed
the
aggregator-followup
branch
from
f50ae5e
to
f9428fc
Compare
srknzl
approved these changes
Aug 16, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were couple of missing things in the community PR for the
aggregators. This is an attempt to fix those. Namely,
For them, some identified factories are also added, as they
have different return values.