Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[API-704] v5 SQL: Update documentation #461

Merged
merged 3 commits into from
Sep 15, 2021

Conversation

mdumandag
Copy link
Contributor

Updates the SQL documentation with the changes done in the reference
manual. This change mainly reorganizes the documentation and adds some
notes about the new capabilities. For the details, we directed users
to the reference manual so that we don't have to duplicate most parts
of the reference manual which can change frequently.

@mdumandag mdumandag added this to the 5.0 milestone Aug 27, 2021
@mdumandag mdumandag self-assigned this Aug 27, 2021
@srknzl srknzl self-requested a review August 27, 2021 12:54
@srknzl
Copy link
Member

srknzl commented Sep 1, 2021

@mdumandag rebase please?

@mdumandag
Copy link
Contributor Author

@srknzl I did that, but I expect some changes in the Hazelcast reference manual after recent changes (removal of implicit mappings, json -> json-flat, etc.), so I will wait for them. You could review it now, if you want, but note that I might change a couple of things based on the updates to the Hazelcast reference manual

@codecov-commenter
Copy link

codecov-commenter commented Sep 1, 2021

Codecov Report

Merging #461 (5195975) into master (5c88fdf) will decrease coverage by 0.36%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #461      +/-   ##
==========================================
- Coverage   95.18%   94.81%   -0.37%     
==========================================
  Files         345      345              
  Lines       17633    17633              
==========================================
- Hits        16784    16719      -65     
- Misses        849      914      +65     
Impacted Files Coverage Δ
...otocol/codec/client_authentication_custom_codec.py 50.00% <0.00%> (-23.81%) ⬇️
hazelcast/reactor.py 81.79% <0.00%> (-8.26%) ⬇️
hazelcast/invocation.py 93.10% <0.00%> (-2.69%) ⬇️
hazelcast/connection.py 91.03% <0.00%> (-2.16%) ⬇️
hazelcast/protocol/client_message.py 93.52% <0.00%> (-1.77%) ⬇️
hazelcast/statistics.py 91.01% <0.00%> (+0.59%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5c88fdf...5195975. Read the comment docs.

Updates the SQL documentation with the changes done in the reference
manual. This change mainly reorganizes the documentation and adds some
notes about the new capabilities. For the details, we directed users
to the reference manual so that we don't have to duplicate most parts
of the reference manual which can change frequently.
docs/using_python_client_with_hazelcast_imdg.rst Outdated Show resolved Hide resolved
docs/using_python_client_with_hazelcast_imdg.rst Outdated Show resolved Hide resolved
Copy link
Member

@srknzl srknzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving but I hope you add a fix for my comment #461 (comment)

@mdumandag mdumandag merged commit cbacc79 into hazelcast:master Sep 15, 2021
@mdumandag mdumandag deleted the sql-documentation branch September 15, 2021 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants