Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[API-876] Provide suggestions for the HazelcastSqlError #473

Merged
merged 1 commit into from
Sep 16, 2021

Conversation

mdumandag
Copy link
Contributor

Recently, an enhancement is implemented on the server-side to provide
suggestions to execute in case of SqlErrors. The main use case is to
provide the CREATE MAPPING query suggestions in case there exists
a map and there are some entries on it.

The documentation of this feature will be provided in the upcoming
SQL documentation update PR.

Protocol PR: hazelcast/hazelcast-client-protocol#398
Closes #470

@mdumandag mdumandag added this to the 5.0 milestone Sep 14, 2021
@mdumandag mdumandag self-assigned this Sep 14, 2021
@mdumandag mdumandag changed the title Provide suggestions for the HazelcastSqlError [API-876] Provide suggestions for the HazelcastSqlError Sep 14, 2021
Recently, an enhancement is implemented on the server-side to provide
suggestions to execute in case of SqlErrors. The main use case is to
provide the `CREATE MAPPING` query suggestions in case there exists
a map and there are some entries on it.

The documentation of this feature will be provided in the upcoming
SQL documentation update PR.
@codecov-commenter
Copy link

Codecov Report

Merging #473 (3433ffe) into master (5c88fdf) will decrease coverage by 0.39%.
The diff coverage is 94.44%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #473      +/-   ##
==========================================
- Coverage   95.18%   94.79%   -0.40%     
==========================================
  Files         345      345              
  Lines       17633    17644      +11     
==========================================
- Hits        16784    16725      -59     
- Misses        849      919      +70     
Impacted Files Coverage Δ
hazelcast/protocol/codec/custom/sql_error_codec.py 75.00% <85.71%> (+1.66%) ⬆️
hazelcast/sql.py 97.28% <100.00%> (+0.02%) ⬆️
...otocol/codec/client_authentication_custom_codec.py 50.00% <0.00%> (-23.81%) ⬇️
hazelcast/reactor.py 80.09% <0.00%> (-9.96%) ⬇️
hazelcast/connection.py 90.86% <0.00%> (-2.33%) ⬇️
hazelcast/statistics.py 88.62% <0.00%> (-1.80%) ⬇️
hazelcast/invocation.py 94.63% <0.00%> (-1.15%) ⬇️
hazelcast/proxy/base.py 97.40% <0.00%> (-0.65%) ⬇️
hazelcast/six.py 66.95% <0.00%> (-0.22%) ⬇️
hazelcast/listener.py 94.23% <0.00%> (+1.92%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5c88fdf...3433ffe. Read the comment docs.

Copy link

@zpqrtbnk zpqrtbnk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me (will do same in C#...)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[TRACKING ISSUE] Provide CREATE MAPPING suggestion on existing but not mapped IMap exception
3 participants