[BACKPORT] Send TCP metrics for bytes sent and received to server #500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It would be good to send `tcp.bytesReceived` and `tcp.bytesSend` metrics in the metrics blob to the server, so that, someone can track how much traffic is passing between the server and the client. I have manually tested the stats exported to Prometheus and verified that these two new stats are displayed there correctly.
Codecov Report
@@ Coverage Diff @@
## 5.0.z #500 +/- ##
==========================================
- Coverage 95.22% 94.87% -0.36%
==========================================
Files 346 346
Lines 17680 17696 +16
==========================================
- Hits 16836 16789 -47
- Misses 844 907 +63
Continue to review full report at Codecov.
|
srknzl
approved these changes
Oct 14, 2021
Comment on lines
+6
to
+10
| - '[45].*.z' | ||
| pull_request: | ||
| branches: | ||
| - master | ||
| - 4.*.z | ||
| - '[45].*.z' |
There was a problem hiding this comment.
Does it matter to change this? I think the one in master might be the only file that matters.
There was a problem hiding this comment.
No, it is using the workflow files in this branch AFAIK
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It would be good to send
tcp.bytesReceivedandtcp.bytesSendmetrics in the metrics blob to the server, so that, someone can
track how much traffic is passing between the server and the client.
I have manually tested the stats exported to Prometheus and verified
that these two new stats are displayed there correctly.