Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

publish_all() method for Topic [API-1529] #570

Merged
merged 8 commits into from
Oct 26, 2022

Conversation

mehmettokgoz
Copy link
Contributor

Added codec for publish all message.

@codecov-commenter
Copy link

codecov-commenter commented Sep 5, 2022

Codecov Report

Merging #570 (d2f0077) into master (06a48e8) will decrease coverage by 0.01%.
The diff coverage is 96.55%.

@@            Coverage Diff             @@
##           master     #570      +/-   ##
==========================================
- Coverage   96.47%   96.45%   -0.02%     
==========================================
  Files         355      349       -6     
  Lines       20351    19604     -747     
==========================================
- Hits        19633    18909     -724     
+ Misses        718      695      -23     
Impacted Files Coverage Δ
hazelcast/proxy/topic.py 96.72% <94.11%> (-1.01%) ⬇️
...azelcast/protocol/codec/topic_publish_all_codec.py 100.00% <100.00%> (ø)
hazelcast/proxy/map.py 97.82% <0.00%> (-0.43%) ⬇️
hazelcast/__init__.py
hazelcast/proxy/cp/__init__.py
hazelcast/proxy/__init__.py
hazelcast/util.py
hazelcast/client.py
hazelcast/compact.py
hazelcast/serialization/__init__.py
... and 1 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@yuce
Copy link
Contributor

yuce commented Sep 23, 2022

@mehmettokgoz Could you add a test for this?

Copy link
Contributor

@mdumandag mdumandag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, please add tests

hazelcast/protocol/codec/topic_publish_all_codec.py Outdated Show resolved Hide resolved
hazelcast/proxy/topic.py Outdated Show resolved Hide resolved
hazelcast/proxy/topic.py Outdated Show resolved Hide resolved
hazelcast/proxy/topic.py Show resolved Hide resolved
hazelcast/proxy/topic.py Outdated Show resolved Hide resolved
hazelcast/proxy/topic.py Outdated Show resolved Hide resolved
@mehmettokgoz
Copy link
Contributor Author

Added tests for publish_all() under integration tests.

Copy link
Contributor

@mdumandag mdumandag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You also need to add tests to the TopicCompactCompatibilityTest to make sure that your code works with Compact serialized objects as well

hazelcast/proxy/topic.py Outdated Show resolved Hide resolved
hazelcast/proxy/topic.py Outdated Show resolved Hide resolved
@mehmettokgoz
Copy link
Contributor Author

Compact compatibility test is added at 945b965.

@mehmettokgoz mehmettokgoz merged commit c3ba3ee into hazelcast:master Oct 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants