-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
publish_all() method for Topic [API-1529] #570
Conversation
Codecov Report
@@ Coverage Diff @@
## master #570 +/- ##
==========================================
- Coverage 96.47% 96.45% -0.02%
==========================================
Files 355 349 -6
Lines 20351 19604 -747
==========================================
- Hits 19633 18909 -724
+ Misses 718 695 -23
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
3742c90
to
e780eee
Compare
@mehmettokgoz Could you add a test for this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, please add tests
Added tests for publish_all() under integration tests. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You also need to add tests to the TopicCompactCompatibilityTest
to make sure that your code works with Compact serialized objects as well
Compact compatibility test is added at 945b965. |
Added codec for publish all message.