Add tests for Vector Collection backup config #711
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olukas
force-pushed
the
vs-ft-config-tests
branch
from
d4f9d5e
to
372962f
Compare
olukas
force-pushed
the
vs-ft-config-tests
branch
from
372962f
to
9a082ad
Compare
yuce
requested changes
Nov 15, 2024
| name = random_string() | ||
| self.client.create_vector_collection_config( | ||
| name, [IndexConfig("vector", Metric.COSINE, 3)], backup_count=6 | ||
| ) |
There was a problem hiding this comment.
Would it make sense to check whether the VC was created, maybe something like:
client.get_vector_collection(vc_name).blocking()That would raise an exception if the vector collection doesn't exist.
Same comment for tests that creates a VC.
| @@ -181,7 +181,21 @@ def test_backupCount_valid_values_pass(self): | |||
| name, [IndexConfig("vector", Metric.COSINE, 3)], backup_count=2, async_backup_count=2 | |||
| ) | |||
|
|
|||
| def test_backupCount(self): | |||
| def test_backupCount_max_value_pass(self): | |||
There was a problem hiding this comment.
Would it be possible to use lower snake case exclusively for function names, like test_backup_count_max_value_pass?
That's the expected Python style.
I've missed that in previous tests that involve the backup count.
I'll send a PR to fix them.
yuce
approved these changes
Nov 15, 2024
srknzl
approved these changes
Nov 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add tests for setting Vector Collection
backup_countandasync_backup_countconfiguration.