DOC-305: orphan pages detector #428
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
❌ Deploy Preview for frosty-curran-1fc0c4 failed. Why did it fail? →
|
JackPGreen
reviewed
Dec 10, 2024
| @@ -15,3 +15,6 @@ jobs: | |||
| uses: actions/checkout@v4 | |||
| - name: Check dead links | |||
| uses: hazelcast/hazelcast-docs/.github/actions/validate@main | |||
| - name: Check orphan pages | |||
| shell: bash | |||
There was a problem hiding this comment.
Nit - not sure if neccesary.
| @@ -15,3 +15,6 @@ jobs: | |||
| uses: actions/checkout@v4 | |||
| - name: Check dead links | |||
| uses: hazelcast/hazelcast-docs/.github/actions/validate@main | |||
| - name: Check orphan pages | |||
| shell: bash | |||
| run: npm run check-orphan-pages | |||
There was a problem hiding this comment.
Do we need to install a specific version of node?
oliverhowell
approved these changes
Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements https://hazelcast.atlassian.net/browse/DOC-305
Please note, we probably can close https://hazelcast.atlassian.net/browse/DOC-304 if this implementation is OK