Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DOC-353 Prometheus metrics standardization #434

Open
wants to merge 16 commits into
base: main
Choose a base branch
from
Open

DOC-353 Prometheus metrics standardization #434

wants to merge 16 commits into from

Conversation

Rob-Hazelcast
Copy link
Contributor

@Rob-Hazelcast Rob-Hazelcast commented Jan 29, 2025 •
edited
Loading

@Rob-Hazelcast Rob-Hazelcast requested a review from a team as a code owner January 29, 2025 17:19
@Rob-Hazelcast Rob-Hazelcast mentioned this pull request Jan 29, 2025
Open
@netlify Netlify
Copy link

netlify bot commented Jan 29, 2025 •
edited
Loading

✅ Deploy Preview for frosty-curran-1fc0c4 ready!

Name Link
🔨 Latest commit eba88d6
🔍 Latest deploy log https://app.netlify.com/sites/frosty-curran-1fc0c4/deploys/67aa3e9d9048490008d7f1b5
😎 Deploy Preview https://deploy-preview-434--frosty-curran-1fc0c4.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@jgardiner68 jgardiner68 self-requested a review February 4, 2025 14:23
@jgardiner68
Small text changes. Wanting to clarify that MC has a Prometheus Expor…
29fea9b 
…ter so that the customer can use any Prometheus compatible monnitoring tool.
@hazelcast hazelcast deleted a comment from pollett Feb 4, 2025
oliverhowell
oliverhowell approved these changes Feb 6, 2025
View reviewed changes
Copy link
Contributor

@oliverhowell oliverhowell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me - some suggestions but only for consideration so approving in advance

docs/modules/integrate/pages/prometheus-metrics.adoc Show resolved Hide resolved
docs/modules/integrate/pages/prometheus-metrics.adoc Show resolved Hide resolved
docs/modules/integrate/pages/prometheus-monitoring.adoc Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pollett pollett pollett left review comments

@zhmaeff zhmaeff zhmaeff left review comments

@oliverhowell oliverhowell oliverhowell approved these changes

@jgardiner68 jgardiner68 Awaiting requested review from jgardiner68

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Rob-Hazelcast @pollett @zhmaeff @oliverhowell @jgardiner68