Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IZE-585 IZE-577 IZE-580 invalid ize exec command not handled #458

Merged
merged 3 commits into from
Sep 19, 2022
Merged

IZE-585 IZE-577 IZE-580 invalid ize exec command not handled #458

merged 3 commits into from
Sep 19, 2022

Conversation

psihachina
Copy link
Contributor

@psihachina psihachina commented Sep 19, 2022 •
edited
Loading

Changelog:

  • fixed handling of missing commands
  • fixed detection of env parameter in 'ize terraform` command
  • fixed command documentation generation

Tests:

asciicast

asciicast

asciicast

AutomationD
AutomationD requested changes Sep 19, 2022
View reviewed changes
Copy link
Contributor

@AutomationD AutomationD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fixes. Let's address minor but important notes.

internal/commands/doc.go Outdated Show resolved Hide resolved
@psihachina psihachina force-pushed the IZE-577-invalid-ize-exec-command-not-handled branch from 69a91e0 to 15f545f Compare September 19, 2022 12:16
@psihachina psihachina merged commit 04ccacb into main Sep 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AutomationD AutomationD AutomationD approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@psihachina @AutomationD