Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add infra destroy after go tests(ize-586) and copy md files to website/commands (ize-589) #465

Merged
merged 6 commits into from
Sep 22, 2022
Merged

Add infra destroy after go tests(ize-586) and copy md files to website/commands (ize-589) #465

merged 6 commits into from
Sep 22, 2022

Conversation

kobrikx
Copy link
Collaborator

@kobrikx kobrikx commented Sep 21, 2022

What's new:

  • Added infra destroy after go tests

@kobrikx kobrikx changed the title Add infra destroy after go tests Add infra destroy after go tests(ize-586) and copy md files to website/commands (ize-589) Sep 21, 2022
AutomationD
AutomationD requested changes Sep 22, 2022
View reviewed changes
Copy link
Contributor

@AutomationD AutomationD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make sure e2e tests run is successful.

igorkotof
igorkotof approved these changes Sep 22, 2022
View reviewed changes
Copy link
Contributor

@igorkotof igorkotof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm now, thanks

AutomationD
AutomationD approved these changes Sep 22, 2022
View reviewed changes
Copy link
Contributor

@AutomationD AutomationD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, looks good.

.github/workflows/run.e2e-tests.yml Outdated Show resolved Hide resolved
@kobrikx kobrikx merged commit f2a2d1d into main Sep 22, 2022
@kobrikx kobrikx deleted the IZE-586-ecs-clusters-cleaned-up-after-ize-end-to-end-tests branch September 22, 2022 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AutomationD AutomationD AutomationD approved these changes

@igorkotof igorkotof igorkotof approved these changes

@psihachina psihachina Awaiting requested review from psihachina

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kobrikx @AutomationD @igorkotof