Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IZE-516 ize up infra explain bash alternative shown #474

Conversation

psihachina
Copy link
Contributor

Changelog:

  • added explain flag. When explain flag is set, the command shows an alternative to bash that will do exactly what the ize command does

Test:

asciicast

When `explain` flag is set, the command shows an alternative to bash that will do exactly what the ize command does
@codecov-commenter
Copy link

Codecov Report

Merging #474 (a996082) into main (8ebc316) will decrease coverage by 0.61%.
The diff coverage is 7.54%.

@@            Coverage Diff             @@
##             main     #474      +/-   ##
==========================================
- Coverage   30.49%   29.88%   -0.62%     
==========================================
  Files          59       60       +1     
  Lines        7351     7556     +205     
==========================================
+ Hits         2242     2258      +16     
- Misses       4905     5091     +186     
- Partials      204      207       +3     
Impacted Files Coverage Δ
internal/commands/down.go 9.24% <0.00%> (+0.84%) ⬆️
internal/config/config.go 1.37% <0.00%> (-0.29%) ⬇️
internal/config/project.go 0.00% <0.00%> (ø)
internal/terraform/docker.go 0.00% <0.00%> (ø)
internal/commands/up_infra.go 7.85% <0.59%> (-16.48%) ⬇️
internal/commands/up.go 15.03% <5.55%> (+8.15%) ⬆️
internal/commands/down_infra.go 20.98% <7.14%> (-2.55%) ⬇️
internal/commands/up_apps.go 11.81% <11.81%> (ø)
internal/terraform/local.go 68.22% <29.41%> (-3.44%) ⬇️
internal/commands/terraform.go 80.48% <50.00%> (ø)
... and 6 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@AutomationD AutomationD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't include terraform from another PR if possible

@psihachina
Copy link
Contributor Author

psihachina commented Sep 29, 2022

@AutomationD when previous PR will be merged I rebase changes from main.
While watching the last commit

Copy link
Contributor

@AutomationD AutomationD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we please not include changes from the other PR? Please rebase it against the branch of the multistate PR and PR


# Generate Backend.tf
cat << EOF > backend.tf
provider "aws" {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be best to use backend config template as it is actually generated, and not recreate it manually. Can we do that?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No

@psihachina psihachina changed the base branch from main to IZE-582-IZE-361-IZE-446 September 30, 2022 15:04
Copy link
Contributor

@AutomationD AutomationD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK, let's keep it

@AutomationD
Copy link
Contributor

Please rebase too.

@psihachina psihachina merged commit 96cc544 into IZE-582-IZE-361-IZE-446 Sep 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants