-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IZE-516 ize up infra explain bash alternative shown #474
IZE-516 ize up infra explain bash alternative shown #474
Conversation
When `explain` flag is set, the command shows an alternative to bash that will do exactly what the ize command does
Codecov Report
@@ Coverage Diff @@
## main #474 +/- ##
==========================================
- Coverage 30.49% 29.88% -0.62%
==========================================
Files 59 60 +1
Lines 7351 7556 +205
==========================================
+ Hits 2242 2258 +16
- Misses 4905 5091 +186
- Partials 204 207 +3
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please don't include terraform from another PR if possible
@AutomationD when previous PR will be merged I rebase changes from main. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we please not include changes from the other PR? Please rebase it against the branch of the multistate PR and PR
|
||
# Generate Backend.tf | ||
cat << EOF > backend.tf | ||
provider "aws" { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be best to use backend config template as it is actually generated, and not recreate it manually. Can we do that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks OK, let's keep it
Please rebase too. |
…ain-bash-alternative-shown
Changelog:
explain
flag. Whenexplain
flag is set, the command shows an alternative to bash that will do exactly what the ize command doesTest: