Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IZE-599 ize infra down doesnt run terraform init #475

Conversation

psihachina
Copy link
Contributor

Changelog:

added call terraform init before terraform destroy in ize down/ize down infra commands

Test:

asciicast

@codecov-commenter
Copy link

Codecov Report

Merging #475 (5e71166) into main (8ebc316) will decrease coverage by 0.36%.
The diff coverage is 8.47%.

@@            Coverage Diff             @@
##             main     #475      +/-   ##
==========================================
- Coverage   30.49%   30.12%   -0.37%     
==========================================
  Files          59       60       +1     
  Lines        7351     7491     +140     
==========================================
+ Hits         2242     2257      +15     
- Misses       4905     5027     +122     
- Partials      204      207       +3     
Impacted Files Coverage Δ
internal/commands/down.go 8.94% <0.00%> (+0.54%) ⬆️
internal/commands/up_infra.go 10.00% <0.00%> (-14.33%) ⬇️
internal/config/config.go 1.41% <0.00%> (-0.25%) ⬇️
internal/config/project.go 0.00% <0.00%> (ø)
internal/terraform/docker.go 0.00% <0.00%> (ø)
internal/commands/up.go 15.03% <5.55%> (+8.15%) ⬆️
internal/commands/down_infra.go 20.98% <7.14%> (-2.55%) ⬇️
internal/commands/up_apps.go 11.81% <11.81%> (ø)
internal/terraform/local.go 68.22% <29.41%> (-3.44%) ⬇️
internal/commands/terraform.go 80.48% <50.00%> (ø)
... and 6 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@AutomationD AutomationD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't include changes from multistate in this PR

@psihachina psihachina changed the base branch from main to IZE-582-IZE-361-IZE-446 September 30, 2022 15:05
Copy link
Contributor

@AutomationD AutomationD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@psihachina psihachina merged commit ef786cb into IZE-582-IZE-361-IZE-446 Sep 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants