Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade ecs-apps-monorepo #497

Merged
merged 1 commit into from
Oct 12, 2022
Merged

Upgrade ecs-apps-monorepo #497

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 4 additions & 9 deletions examples/ecs-apps-monorepo/.ize/env/testnut/main.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ resource "aws_key_pair" "root" {
}

module "vpc" {
source = "terraform-aws-modules/vpc/aws"
source = "registry.terraform.io/terraform-aws-modules/vpc/aws"
version = "~> 3.0"

name = "${var.env}-vpc"
Expand All @@ -31,13 +31,8 @@ module "vpc" {
"10.0.4.0/24"
]

enable_nat_gateway = true
enable_nat_gateway = true
single_nat_gateway = true
enable_s3_endpoint = true
enable_ecr_api_endpoint = true
ecr_api_endpoint_security_group_ids = [aws_security_group.default_permissive.id]
enable_ecr_dkr_endpoint = true
ecr_dkr_endpoint_security_group_ids = [aws_security_group.default_permissive.id]
enable_dns_hostnames = true
manage_default_network_acl = true
default_network_acl_name = "${var.env}-${var.namespace}"
Expand Down Expand Up @@ -92,14 +87,14 @@ resource "aws_security_group" "default_permissive" {
}

module "ecs" {
source = "terraform-aws-modules/ecs/aws"
source = "registry.terraform.io/terraform-aws-modules/ecs/aws"
version = "~> 3.0"
name = "${var.env}-${var.namespace}"

}

module "ec2_profile" {
source = "terraform-aws-modules/ecs/aws//modules/ecs-instance-profile"
source = "registry.terraform.io/terraform-aws-modules/ecs/aws//modules/ecs-instance-profile"
version = "~> 3.0"
name = "${var.env}-${var.namespace}"
include_ssm = true
Expand Down
4 changes: 2 additions & 2 deletions examples/ecs-apps-monorepo/.ize/env/testnut/variables.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,13 +14,13 @@ locals {
public_subnets = module.vpc.public_subnets
private_subnets = module.vpc.private_subnets
key_name = aws_key_pair.root.key_name
iam_instance_profile = module.ec2_profile.this_iam_instance_profile_id
iam_instance_profile = module.ec2_profile.iam_instance_profile_id
root_domain_name = var.root_domain_name
zone_id = aws_route53_zone.env_domain.id
vpc_id = module.vpc.vpc_id
security_groups = [aws_security_group.default_permissive.id]
alb_security_groups = [aws_security_group.default_permissive.id]
docker_registry = var.docker_registry
docker_image_tag = var.docker_image_tag
ecs_cluster_name = module.ecs.this_ecs_cluster_name
ecs_cluster_name = module.ecs.ecs_cluster_name
}