Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IZE-592 IZE-665 start ecs task #499

Merged
merged 3 commits into from
Oct 17, 2022
Merged

IZE-592 IZE-665 start ecs task #499

merged 3 commits into from
Oct 17, 2022

Conversation

psihachina
Copy link
Contributor

Change:

added ize start <app_name> command

Test:

asciicast

@codecov-commenter
Copy link

Codecov Report

Merging #499 (3a84297) into main (73b6f12) will decrease coverage by 0.40%.
The diff coverage is 13.29%.

@@            Coverage Diff             @@
##             main     #499      +/-   ##
==========================================
- Coverage   31.86%   31.45%   -0.41%     
==========================================
  Files          60       61       +1     
  Lines        7727     7897     +170     
==========================================
+ Hits         2462     2484      +22     
- Misses       5028     5175     +147     
- Partials      237      238       +1     
Impacted Files Coverage Δ
internal/config/config.go 1.37% <0.00%> (ø)
internal/commands/start.go 10.30% <10.30%> (ø)
internal/commands/ize.go 67.76% <100.00%> (+0.26%) ⬆️
internal/commands/logs.go 70.70% <100.00%> (+1.23%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@AutomationD AutomationD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Might need some more language updates and a test for missing configs. but for now it's OK.

internal/config/config.go Show resolved Hide resolved
@psihachina psihachina changed the title IZE-592 start ecs task IZE-592 IZE-665 start ecs task Oct 14, 2022
Copy link
Contributor

@igorkotof igorkotof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but let's discuss renaming startto run later

@psihachina psihachina merged commit 2691708 into main Oct 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants