Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Main environment parameters read from conventional env vars (TOOLS-186) #79

Merged
merged 2 commits into from
Jan 15, 2022
Merged

Main environment parameters read from conventional env vars (TOOLS-186) #79

merged 2 commits into from
Jan 15, 2022

Conversation

AutomationD
Copy link
Contributor

@AutomationD AutomationD commented Jan 15, 2022 •
edited
Loading

Add ability to read the following env vars:

  • ENV
  • AWS_PROFILE
  • AWS_REGION
  • NAMESPACE
    In addition to IZE_* prefixed-ones

asciicast

@AutomationD AutomationD changed the title Feature/read common env vars Main environment parameters read from conventional env vars (TOOLS-186) Jan 15, 2022
psihachina
psihachina approved these changes Jan 15, 2022
View reviewed changes
Copy link
Contributor

@psihachina psihachina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but no test

@AutomationD
Copy link
Contributor Author

@psihachina added tests

@AutomationD AutomationD merged commit 6678abc into main Jan 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@psihachina psihachina psihachina approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AutomationD @psihachina