forked from oslabs-beta/sapling
-
Notifications
You must be signed in to change notification settings - Fork 8
feat(parser): Update parsing logic to use Babel type guards #14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- also added entry for .DS_Store
…babel type guards
- replace `level` with `depth` on webview side
…features - array and object destructuring for require statements - array and object destructuring for dynamic imports
Add support for require, dynamic import statements, decouple tree state from parser
- Error was due to import path used in `SaplingParser` (`../src/types`) escaping `rootDir` defined in `tsconfig.json`.
feat: require, dynamic import statements, decouple tree state from parser
- SaplingParser, SaplingTree internally use `Tree` type instead of `INode`.
- All parser tests passing.
Parser/babel type guards: all tests passing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #7