Android: fix 'Descriptor None was not found!' #1580
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dlech
reviewed
May 23, 2024
vabt-igd
force-pushed
the
fix_android_descriptor_none
branch
from
bee4d86 to
0b042fa
Compare
dlech
requested changes
May 23, 2024
vabt-igd
force-pushed
the
fix_android_descriptor_none
branch
from
254167d to
6907ead
Compare
|
I think, this should be it now. Sorry for the mess. |
dlech
reviewed
May 23, 2024
dlech
approved these changes
May 23, 2024
|
Thanks for testing again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the 128bit UUID plus the Bluetooth base UUID for the notification descriptor on android devices. This fixes
Descriptor None was not found!exceptions, as discussed in #823.On the three android devices (API Level 33 and 32) I tested, this seems to work reliably.
As this is just a minor fix, I did not add an entry to the
CHANGELOG.rst.Let me know if that should be changed.
This fix may also address #828.