Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for head and tail port #34

Merged
merged 2 commits into from
Jul 2, 2024
Merged

Conversation

haisland0909
Copy link
Contributor

I got error when I write edge with headport and tailport option.
The error caused by pygraphviz.
When pygraphviz creates svg file from dot file with headport and tailport option, the title becomes
"source:tailport->target:headport" and EdgeFactory looks it as key of edge dict.

@codecov
Copy link

codecov bot commented Oct 20, 2020

Codecov Report

Merging #34 into master will increase coverage by 0.81%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #34      +/-   ##
==========================================
+ Coverage   76.94%   77.75%   +0.81%     
==========================================
  Files          23       23              
  Lines         590      598       +8     
==========================================
+ Hits          454      465      +11     
+ Misses        136      133       -3     
Impacted Files Coverage Δ
graphviz2drawio/mx/EdgeFactory.py 100.00% <100.00%> (ø)
graphviz2drawio/mx/MxGraph.py 88.40% <100.00%> (+1.44%) ⬆️
graphviz2drawio/mx/CurveFactory.py 100.00% <0.00%> (+4.34%) ⬆️
graphviz2drawio/mx/GraphObj.py 100.00% <0.00%> (+12.50%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 51d3c66...bd08edf. Read the comment docs.

@hbmartin hbmartin merged commit 125a94e into hbmartin:master Jul 2, 2024
@hbmartin
Copy link
Owner

hbmartin commented Jul 2, 2024

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants