Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust schema space URI #296

Closed
acka47 opened this issue Oct 25, 2021 · 2 comments
Closed

Adjust schema space URI #296

acka47 opened this issue Oct 25, 2021 · 2 comments

Comments

@acka47
Copy link
Contributor

acka47 commented Oct 25, 2021

Currently, the schema space of the lobid-gnd reconciliation endpoint is https://d-nb.info/standards/elementset/gnd#AuthorityResource, see $ curl https://lobid.org/gnd/reconcile | jq -r .schemaSpace.

As far as I understand this, it should be the namespace of the GND ontology, i.e. https://d-nb.info/standards/elementset/gnd#. The draft spec about schema space:

A URI which identifies the ontology used by the service, in other words its collection of properties. This URI also MAY resolve to a page describing these properties and their identifiers.
acka47 added a commit that referenced this issue Oct 25, 2021
@acka47
Adjust schema space URI (#296)
03af9e8
@acka47 acka47 mentioned this issue Oct 25, 2021
Closed
@fsteeg
Copy link
Member

fsteeg commented Oct 26, 2021

Hm, my understanding was that the schemaSpace is "the URL that identifies the type of entity returned by the reconciliation service" (see b77a5ee). But I guess that discussion did not make it into the specs (yet?). @wetneb, any thoughts on this? (Issue was reconciliation-api/specs#3)

@acka47 acka47 mentioned this issue Oct 26, 2021
Closed
acka47 added a commit to reconciliation-api/specs that referenced this issue Oct 26, 2021
@acka47
Adjust definition of schema space (#3)
5546ada 
based on https://lists.w3.org/Archives/Public/public-reconciliation/2019Oct/0002.html,
bumped by discussion in hbz/lobid-gnd#296.
@acka47
Copy link
Contributor Author

acka47 commented Oct 26, 2021

Ah, ok. I wasn't aware of this. In this case, everything is fine. I opened a PR to update the spec at reconciliation-api/specs#76. Closing this issue and the corresponding PR.

@acka47 acka47 closed this as completed Oct 26, 2021
wetneb pushed a commit to reconciliation-api/specs that referenced this issue Nov 16, 2021
@acka47 @fsteeg @thadguidry
Adjust definition of schema space (#76)
c26488d 
* Adjust definition of schema space (#3)

based on https://lists.w3.org/Archives/Public/public-reconciliation/2019Oct/0002.html,
bumped by discussion in hbz/lobid-gnd#296.

* Adjust definitions of identifier and schema space (#3, #76)

Joining suggestions by Adrian and Thad, tweaked for consistency

Co-authored-by: Adrian Pohl <pohl@hbz-nrw.de>
Co-authored-by: Thad Guidry <thadguidry@gmail.com>

Co-authored-by: Fabian Steeg <steeg@hbz-nrw.de>
Co-authored-by: Thad Guidry <thadguidry@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Adjust schema space URI hbz/lobid-gnd
2 participants
@fsteeg @acka47