Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow export as tsv #500

Merged
merged 7 commits into from
Nov 27, 2023
Merged

Allow export as tsv #500

merged 7 commits into from
Nov 27, 2023

Conversation

dr0i
Copy link
Member

@dr0i dr0i commented Sep 28, 2023

@dr0i dr0i requested a review from fsteeg September 28, 2023 13:30
@dr0i dr0i requested a review from TobiasNx September 28, 2023 14:43
@dr0i dr0i marked this pull request as ready for review September 29, 2023 07:20
@dr0i
Copy link
Member Author

dr0i commented Sep 29, 2023

@TobiasNx you can do functional review at test instance. See api description of how to use it http://test.lobid.org/organisations/api/en.

@dr0i
Copy link
Member Author

dr0i commented Sep 29, 2023

Wait, @TobiasNx asks to remove quotation marks (marking the start and end of a value).

@fsteeg fsteeg removed their request for review September 29, 2023 08:37
@fsteeg fsteeg removed their assignment Sep 29, 2023
@TobiasNx
Copy link
Contributor

TobiasNx commented Oct 2, 2023

@dr0i you still need to change the behaviour for quotiations right?

@TobiasNx TobiasNx assigned dr0i and unassigned TobiasNx Oct 2, 2023
@TobiasNx
Copy link
Contributor

@dr0i did you finish this? It is needed for: hbz/lobid-resources#1903

@dr0i dr0i force-pushed the 1903-allowExportAsTsv branch from 13f194a to f530ad8 Compare November 27, 2023 10:25
@dr0i dr0i merged commit 5abfb36 into master Nov 27, 2023
1 check passed
@dr0i dr0i deleted the 1903-allowExportAsTsv branch November 27, 2023 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants