-
Notifications
You must be signed in to change notification settings - Fork 7
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge branch 'master' into 2000-orderElements
- Loading branch information
Showing
201 changed files
with
20,051 additions
and
1,258 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,17 @@ | ||
# Contributing to lobid-resources | ||
|
||
|
||
Welcome! Thank you for contributing to lobid-resources. | ||
|
||
## How can I contribute? | ||
|
||
Follow the instructions from [metafacture-playground's CONTRIBUTING.md, section "How can I contribute?"](https://github.com/metafacture/metafacture-playground/blob/main/CONTRIBUTING.md#table-of-contents). | ||
|
||
**Note**: | ||
|
||
We differ from the above documentation when doing **Pull Requests**(PR). | ||
As a functional review of a PR normally needs a full indexing, which takes around 18h, the PR should not be linked to the issue by a "closing keyword" but with a "See", eg "**See #2002.**". So if the PR is merged and thus closed, it doesn't trigger the closing of the issue automatically. The issue should be revisited after weekend's deployment and checked if the PR indeed has solved the issue. It is then closed manually. | ||
|
||
**If** an issue is **assigned** it shall always be clear for the assigned what is expected of her. E.g. one could assign and comment with: "Check after weekend's deployment". | ||
|
||
To have the Issue and also the PR appear at [lobid-resources' GitHub Board](https://github.com/orgs/hbz/projects/11/views/1) add them via **Projects** (see at the right side). Change the Status properly, e.g. to "Review). Don't forget to also assign the PR and the Issue. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.