Merge #1904 from branch 'DeleteUnnecessaryIsilRedirectLookup' of http…

…s://github.com/hbz/lobid-resources
hbz · Sep 28, 2023 · dff8527 · dff8527
2 parents 35ff397 + 7124232
commit dff8527
Show file tree

Hide file tree

Showing 4 changed files with 0 additions and 5 deletions.
diff --git a/src/main/java/org/lobid/resources/run/AlmaMarcXmlFix2lobidJsonEs.java b/src/main/java/org/lobid/resources/run/AlmaMarcXmlFix2lobidJsonEs.java
@@ -127,7 +127,6 @@ public void run() {
                 fixVariables.put("almaMmsId2rpbId", "../../../../../../lookup-tables/data/almaMmsId2rpbId.tsv");
                 fixVariables.put("lobidOrganisationsMapping.tsv", "./maps/lobidOrganisationsMapping.tsv");
                 fixVariables.put("hbzowner2sigel.tsv", "./maps/hbzowner2sigel.tsv");
-                fixVariables.put("isilRedirect.tsv", "./maps/isilRedirect.tsv");
                 fixVariables.put("rpb2.ttl", "../../../../../../vocabs/rpb/rpb2.ttl");
                 fixVariables.put("rpb-spatial.ttl", "../../../../../../vocabs/rpb/rpb-spatial.ttl");
                 fixVariables.put("rpb.ttl", "../../../../../../vocabs/rpb/rpb.ttl");

diff --git a/src/main/resources/alma/fix/item.fix b/src/main/resources/alma/fix/item.fix
@@ -21,7 +21,6 @@ do list(path:"ITM  ", "var": "$i")
     copy_field("$i.w","$i.@sublibraryIsil")
     lookup("$i.@sublibraryIsil", "hbzowner2sigel",delete:"true")
     lookup("$i.@sublibraryIsil", "sigel2isilMap",delete:"true")
-    lookup("$i.@sublibraryIsil", "isilRedirect")     
     # following fix checks for sublibrary codes and if they map to provided sublocation Isil
     unless exists("$i.@sublibraryIsil")
       paste("$i.@sublibraryIsil","$i.M","~+","$i.w",join_char:"")
@@ -62,7 +61,6 @@ do list(path: "HOL  ", "var": "$i")
           copy_field("$H52.b","$i.@sublibraryIsil")
           lookup("$i.@sublibraryIsil", "hbzowner2sigel",delete:"true")
           lookup("$i.@sublibraryIsil", "sigel2isilMap",delete:"true") 
-          lookup("$i.@sublibraryIsil", "isilRedirect")       
           # following fix checks for sublibrary codes and if they map to provided sublocation Isil
           unless exists("$i.@sublibraryIsil")
             paste("$i.@sublibraryIsil","$i.M","~+","$H52.b",join_char:"")

diff --git a/src/main/resources/alma/fix/maps.fix b/src/main/resources/alma/fix/maps.fix
@@ -9,7 +9,6 @@ put_filemap("$[lobidOrganisationsMapping.tsv]","lobidOrgLabels", sep_char:"\t",k
 
 put_filemap("$[lobidOrganisationsMapping.tsv]","sigel2isilMap", sep_char:"\t",key_column:"2",value_column:"1",expected_columns:"-1")
 put_filemap("$[hbzowner2sigel.tsv]","hbzowner2sigel", sep_char:"\t",key_column:"0",value_column:"2",expected_columns:"-1")
-put_filemap("$[isilRedirect.tsv]","isilRedirect", sep_char:"\t",key_column:"1",value_column:"0",expected_columns:"-1")
 
 put_filemap("$[picaCreatorId2Isil.tsv]","picaCreatorId2Isil", sep_char:"\t", sep_char:"\t",key_column:"0",value_column:"2",expected_columns:"-1")
 

diff --git a/src/test/java/org/lobid/resources/AlmaMarc21XmlToLobidJsonMetafixTest.java b/src/test/java/org/lobid/resources/AlmaMarc21XmlToLobidJsonMetafixTest.java
@@ -71,7 +71,6 @@ public void setup() {
         fixVariables.put("almaMmsId2rpbId", "src/test/resources/alma/maps/almaMmsId2rpbId.tsv");
         fixVariables.put("lobidOrganisationsMapping.tsv", "src/main/resources/alma/maps/lobidOrganisationsMapping.tsv");
         fixVariables.put("hbzowner2sigel.tsv", "src/main/resources/alma/maps/hbzowner2sigel.tsv");
-        fixVariables.put("isilRedirect.tsv", "src/main/resources/alma/maps/isilRedirect.tsv");
         fixVariables.put("rpb2.ttl", "src/test/resources/alma/maps/rpb2.ttl");
         fixVariables.put("rpb-spatial.ttl", "src/test/resources/alma/maps/rpb-spatial.ttl");
         fixVariables.put("rpb.ttl", "src/test/resources/alma/maps/rpb.ttl");