Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement MARC 264$#3$ (Manufacture) #1806

Closed
blackwinter opened this issue Jun 23, 2023 · 10 comments · Fixed by #1896
Closed

Implement MARC 264$#3$ (Manufacture) #1806

blackwinter opened this issue Jun 23, 2023 · 10 comments · Fixed by #1896
Assignees
Milestone

Comments

@blackwinter
Copy link
Member

blackwinter commented Jun 23, 2023

HT016692738 should include the "Manufacture place and date" (MARC 264$#3$); possibly modelled after 264$#1$ (publication).

<datafield tag="264" ind1=" " ind2="3">
  <subfield code="a">Marsberg</subfield>
  <subfield code="b">Boxberger</subfield>
  <subfield code="c">2010</subfield>
</datafield>

Also: Would it make sense to use 008/07-10 (Date 1) as fallback for publication.startDate?

Originally reported as DigiBib-Ticket#2023062250336954.

@TobiasNx
Copy link
Contributor

TobiasNx commented Sep 7, 2023

It seems that there are no fitting properties for manufacture/production that correspondent to publication

Perhaps:
http://www.rdaregistry.info/Elements/m/#P30053

But seems to be a note element.

@TobiasNx
Copy link
Contributor

TobiasNx commented Sep 7, 2023

HT016692738 should include the "Manufacture place and date" (MARC 264$#3$); possibly modelled after 264$#1$ (publication).

<datafield tag="264" ind1=" " ind2="3">
  <subfield code="a">Marsberg</subfield>
  <subfield code="b">Boxberger</subfield>
  <subfield code="c">2010</subfield>
</datafield>

Also: Would it make sense to use 008/07-10 (Date 1) as fallback for publication.startDate?

Originally reported as DigiBib-Ticket#2023062250336954.

btw.:

in the DNB there is also another publisher listed with ind 1: https://portal.dnb.de/opac.htm?method=simpleSearch&cqlMode=true&query=idn%3D1009900439

http://d-nb.info/1009900439/about/marcxml

TobiasNx added a commit that referenced this issue Sep 18, 2023
TobiasNx added a commit that referenced this issue Sep 18, 2023
TobiasNx added a commit that referenced this issue Sep 19, 2023
TobiasNx added a commit that referenced this issue Sep 21, 2023
@acka47
Copy link
Contributor

acka47 commented Sep 21, 2023

Re. the data modelling in RDF, there are excisting properties, both in schema.org and RDA unconstrained properties:

schema.org has two bespoke properties that would be used instead of the event-based approach we have for publication (originated in lobid/lodmill#730):

What is missing for our needs is productionLocation. Also, if we used this, we would have it modeled in a completely different way than publication. Thus, this does not fit our use case.

It is similar with RDA:

However, RDA has the same problem that it would be modeled in a completely different way than publication. Thus the general approach in #1896 makes sense. I will comment on details in the PR.

TobiasNx added a commit that referenced this issue Sep 21, 2023
@TobiasNx TobiasNx moved this from Ready to Review in lobid-resources Sep 22, 2023
TobiasNx added a commit that referenced this issue Sep 22, 2023
@github-project-automation github-project-automation bot moved this from Review to Done in lobid-resources Sep 22, 2023
@TobiasNx
Copy link
Contributor

@TobiasNx TobiasNx reopened this Sep 25, 2023
@TobiasNx
Copy link
Contributor

This should be added to the GUI too and also the lobid vocab should be updated.

@dr0i dr0i moved this from Done to Ready in lobid-resources Sep 25, 2023
@dr0i
Copy link
Member

dr0i commented Sep 25, 2023

The manufacture and manufacturedBy properties are missing in the context(<= labels.json).

@dr0i
Copy link
Member

dr0i commented Oct 13, 2023

Is this solved @TobiasNx ?

@dr0i dr0i moved this from Ready to Review in lobid-resources Oct 19, 2023
@TobiasNx
Copy link
Contributor

manufacture needs to be presented in the GUI before closing.
Lets do this similar to publication.

But change manufacture and publication to one property segment per array not as many as objects in the array:
grafik

@dr0i dr0i assigned dr0i and unassigned TobiasNx Jan 12, 2024
@dr0i dr0i added the Web-App label Jan 12, 2024
@dr0i
Copy link
Member

dr0i commented Apr 22, 2024

If I recollect properly we agreed at Friday that this issue can be closed and be opened again if anyone needs it actually. @TobiasNx said this issue is solved at nwbib repo and wanted to link to respectively PR so that we can easily copy the code if need arises.

@dr0i dr0i assigned TobiasNx and unassigned dr0i Apr 22, 2024
@TobiasNx
Copy link
Contributor

TobiasNx commented May 7, 2024

This was the issue in nwbib: hbz/nwbib#627 and this the PR: hbz/nwbib#640

So then we decide to close this.
Until somebody asks for manufacturer in the GUI.

@TobiasNx TobiasNx closed this as completed May 7, 2024
@github-project-automation github-project-automation bot moved this from Review to Done in lobid-resources May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

4 participants