Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ISSN with - #1828

Closed
TobiasNx opened this issue Jul 25, 2023 · 5 comments · Fixed by #1916
Closed

ISSN with - #1828

TobiasNx opened this issue Jul 25, 2023 · 5 comments · Fixed by #1916
Assignees

Comments

@TobiasNx
Copy link
Contributor

TobiasNx commented Jul 25, 2023

- needs do be deleted in ISSN: http://lobid.org/resources/99370698912306441

Based on Issue in JIRA bei Fachrepositorium Lebenswissenschaften.

@TobiasNx
Copy link
Contributor Author

@acka47 or @fsteeg is it intentional that the "related" ISSN is presented in the GUI:
grafik

  "related": [
    {
      "issn": "2364-4893"
    }
  ]

based on: http://lobid.org/resources/99370698912306441.json

TobiasNx added a commit that referenced this issue Sep 29, 2023
TobiasNx added a commit that referenced this issue Oct 2, 2023
TobiasNx added a commit that referenced this issue Apr 2, 2024
This also highlights the different behavion from q.all to the general lobid-search.
@TobiasNx
Copy link
Contributor Author

TobiasNx commented Apr 4, 2024

Ping @fsteeg and @acka47

I assume this showing the related.issn is an error, right.
The GUI is stating the wrong ISSN. But if I am not mistaken, the code in the detail page is not
specific which ISSN it shows:

@result_field("ISSN", "issn", doc, TableRow.VALUES)
@withPrefixedLink("DOI", "https://dx.doi.org/", doc \ "doi")

@TobiasNx TobiasNx mentioned this issue Apr 4, 2024
@fsteeg
Copy link
Member

fsteeg commented Apr 9, 2024

I assume this showing the related.issn is an error, right.

Yes, same as in NWBib (hbz/nwbib#636), where it's fixed (hbz/nwbib#644).

dr0i added a commit that referenced this issue Apr 16, 2024
The related.issn is now stored without hyphen.
@github-project-automation github-project-automation bot moved this from Backlog to Done in lobid-resources Apr 16, 2024
@TobiasNx
Copy link
Contributor Author

@dr0i GUI is still wrong, isn't it. at least it is showing the related.issn but there is also a separate ticket: #1829

@dr0i
Copy link
Member

dr0i commented Apr 16, 2024

@TobiasNx yep - this is an other issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants