Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Separate lookup-tables for test and prod and use gitsubmodule for prod #1893

Closed
TobiasNx opened this issue Sep 15, 2023 · 2 comments
Closed

Separate lookup-tables for test and prod and use gitsubmodule for prod #1893

TobiasNx opened this issue Sep 15, 2023 · 2 comments
Assignees
@dr0i

Comments

@TobiasNx
Copy link
Contributor

As already done for DDC.
dr0i added a commit that referenced this issue Sep 18, 2023
@dr0i
Add lookup tables as git submodules (#1893)
240bb88
TobiasNx added a commit that referenced this issue Sep 22, 2023
@TobiasNx
Use local version of cron job ed maps #1893
2dd6338
@TobiasNx TobiasNx mentioned this issue Sep 22, 2023
Closed
dr0i added a commit that referenced this issue Sep 22, 2023
@dr0i
Add lookup tables as git submodules (#1893)
e0baa8a 
Do "git config --global submodule.recurse true" once in your checked out repo.
Further "git pull" will automatically update the submodule.
@dr0i dr0i mentioned this issue Sep 22, 2023
Merged
dr0i added a commit that referenced this issue Sep 25, 2023
@dr0i
Add gitsubmodules section to the README (#1893)
f2d206c 
@blackwinter suggested to use gitsubmodules to easily be in sync
with our repos containing lookup tables.
dr0i added a commit that referenced this issue Sep 25, 2023
@dr0i
Remove unused table (#1893)
ce4e73b
dr0i added a commit that referenced this issue Sep 25, 2023
@dr0i
Test lookup table (#1893)
2e9ac8c 
Complements ce4e73b.
dr0i added a commit that referenced this issue Sep 25, 2023
@dr0i
Improve docu re submodules (#1893)
8338ca9
@dr0i dr0i changed the title Seperate lookup-tables which are picked up by a cron-job from a commited version in the test folder Separate lookup-tables for test and prod and use gitsubmodule for prod Sep 25, 2023
@dr0i dr0i self-assigned this Sep 25, 2023
@dr0i dr0i moved this from Backlog to Deploy in lobid-resources Sep 25, 2023
@dr0i
Copy link
Member

dr0i commented Sep 25, 2023

Separation is done with #1902.
We don't use anymore cronjob to update th lookupt tables but gitsubmodule (as proposed by @blackwinter ).
It's already deployed.
We shall await some live tests with real data before closing this issue.

@dr0i
Copy link
Member

dr0i commented Sep 26, 2023

Seems to be good as there are no errors in the logs.
Closing.

@dr0i dr0i closed this as completed Sep 26, 2023
@github-project-automation github-project-automation bot moved this from Deploy to Done in lobid-resources Sep 26, 2023
dr0i added a commit that referenced this issue Sep 26, 2023
@dr0i
Cache table "isil2opac_hbzid"
bb95fc1 
Don't make a URL lookup to get the concordance every time an item is shown.
Load it th concordance from a gitsubmodule table and cache it as HashMap.

Follows #1893.
dr0i added a commit that referenced this issue Sep 26, 2023
@dr0i
Cache table "isil2opac_hbzid"
e018b4a 
Don't make a URL lookup to get the concordance every time an item is shown.
Load thie concordance from a gitsubmodule table and cache it as HashMap.

Follows #1893.
@dr0i dr0i mentioned this issue Sep 26, 2023
Closed
dr0i added a commit that referenced this issue Sep 26, 2023
@dr0i
Update docu re submodules (#1893)
880219b 
This is necessary for repos that are already cloned and needs to work
with gitsubmodules.
@dr0i dr0i mentioned this issue Oct 13, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dr0i dr0i

Labels
None yet
Projects
lobid-resources
Status: Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dr0i @TobiasNx