Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

related-Transformation creates duplicates if ISBN is given as variant. #1975

Closed
TobiasNx opened this issue Mar 27, 2024 · 2 comments
Closed
Assignees

Comments

@TobiasNx
Copy link
Contributor

While I was away the related-transformation was change to tackle some problems with multiple ids /subfield $w:
#1948
and PR without MR
1911e7b

I found that the changes improved the transformation where multiple Id exist for different variants but create duplicates if the ISBN is identical see:
e6e935b#r140286285

and here:

"related" : [ {
"id" : "http://lobid.org/resources/HT020445679#!",
"note" : [ "Druck-Ausgabe" ],
"isbn" : [ "9783451388798", "3451388790" ],
"label" : "lobid Ressource"
}, {
"isbn" : [ "9783451388798", "3451388790" ]
} ],

@dr0i
Copy link
Member

dr0i commented May 23, 2024

Deployed next Monday.

@TobiasNx
Copy link
Contributor Author

The duplicate is not provided anymore: http://lobid.org/resources/990367731740206441.json

@github-project-automation github-project-automation bot moved this from Review to Done in lobid-resources May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

No branches or pull requests

2 participants