Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include new RPB/LBZ Vocabs as submodule #2063

Closed
TobiasNx opened this issue Aug 29, 2024 · 6 comments
Closed

Include new RPB/LBZ Vocabs as submodule #2063

TobiasNx opened this issue Aug 29, 2024 · 6 comments
Assignees
@dr0i

Comments

@TobiasNx
Copy link
Contributor

TobiasNx commented Aug 29, 2024 •
edited
Loading

RPB, RPB2 and RPB-Spatial moved to:

https://github.com/hbz/lbz-vocabs

@dr0i can you include this as submodule and adjust the paths for the productive java project?

lobid-resources/src/main/java/org/lobid/resources/run/AlmaMarcXmlFix2lobidJsonEs.java

Lines 131 to 133 in 6befacb

fixVariables.put("rpb2.ttl", "../../../../../../vocabs/rpb/rpb2.ttl");
fixVariables.put("rpb-spatial.ttl", "../../../../../../vocabs/rpb/rpb-spatial.ttl");
fixVariables.put("rpb.ttl", "../../../../../../vocabs/rpb/rpb.ttl");

@dr0i dr0i moved this from Backlog to Working in lobid-resources Aug 29, 2024
@acka47
Copy link
Contributor

acka47 commented Aug 29, 2024

Thanks for opening this issue, @TobiasNx ! I didn't know that/how RPB vocabs from hbz/lobid-vocabs was integrated in lobid-resources.

@dr0i dr0i moved this from Working to Backlog in lobid-resources Aug 29, 2024
@dr0i dr0i assigned TobiasNx and unassigned dr0i Aug 29, 2024
@dr0i
Copy link
Member

dr0i commented Aug 29, 2024

Assign me when it's ready @TobiasNx .

@acka47
Copy link
Contributor

acka47 commented Aug 29, 2024

This should be resolved before we merge hbz/lobid-vocabs#230

@TobiasNx TobiasNx assigned dr0i and unassigned TobiasNx Aug 29, 2024
@TobiasNx
Copy link
Contributor Author

@dr0i as @acka47 said hbz/lbz-vocabs can be used now

@TobiasNx TobiasNx moved this from Backlog to Ready in lobid-resources Aug 29, 2024
dr0i added a commit that referenced this issue Aug 29, 2024
@dr0i
Switch from submodule "vocabs" to "lbz-vocabs" (#2063)
26d2f24 
We now use a dedicated vobas rpo for RPB.

- ad git submodule "lbz-vocabs"
- improve README
- configure start script
dr0i added a commit that referenced this issue Aug 29, 2024
@dr0i
Switch from submodule "vocabs" to "lbz-vocabs" (#2063)
0962fe3 
We now use a dedicated vobas rpo for RPB.

- ad git submodule "lbz-vocabs"
- improve README
- configure start script
dr0i added a commit that referenced this issue Aug 29, 2024
@dr0i
Switch from submodule "vocabs" to "lbz-vocabs" (#2063)
61ea3be 
We now use a dedicated vocabs repo for RPB.

- add git submodule "lbz-vocabs"
- improve README
- configure start script
@dr0i dr0i mentioned this issue Aug 29, 2024
Merged
TobiasNx added a commit that referenced this issue Sep 3, 2024
@TobiasNx
Fix test workflow #2063
18532f3
TobiasNx added a commit that referenced this issue Sep 5, 2024
@TobiasNx
Correct path to lbz-vocabs submodul files #2063
46aa4f0
@dr0i
Copy link
Member

dr0i commented Sep 5, 2024

To be reviewed tomorrow after data update.

@dr0i dr0i moved this from Ready to Review in lobid-resources Sep 5, 2024
@dr0i
Copy link
Member

dr0i commented Sep 6, 2024

Looks good now (at first it wasn't deployed probably).
See e.g. http://lobid.org/resources/search?q=describedBy.resultOf.object.dateModified:2024-09-06%20AND%20lbz&format=json.
Closing.

@dr0i dr0i closed this as completed Sep 6, 2024
@github-project-automation github-project-automation bot moved this from Review to Done in lobid-resources Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dr0i dr0i

Labels
None yet
Projects
lobid-resources
Status: Done
Milestone
No milestone
Development

No branches or pull requests
3 participants
@acka47 @dr0i @TobiasNx