Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add almaMmsId and zdbId to IdQuery #2085

Closed
fsteeg opened this issue Oct 29, 2024 · 0 comments · Fixed by #2086
Closed

Add almaMmsId and zdbId to IdQuery #2085

fsteeg opened this issue Oct 29, 2024 · 0 comments · Fixed by #2086

Comments

@fsteeg
Copy link
Member

fsteeg commented Oct 29, 2024

For support in id= search, e.g. these work:

https://lobid.org/resources/search?format=json&id=HT006947724
https://lobid.org/resources/search?format=json&id=929t073764
https://lobid.org/resources/search?format=json&id=09471405

But these don't:

https://lobid.org/resources/search?format=json&id=990055129940206441
https://lobid.org/resources/search?format=json&id=503227-1
https://lobid.org/resources/search?format=json&id=012631833 (dnbId is not searchable and not required for the RPB use case linked below; updated title to exclude it)

Required for https://jira.hbz-nrw.de/browse/RPB-214

For implementation see:

return Arrays.asList("isbn", "issn", "hbzId", "rpbId", "schoeneNummer");

@fsteeg fsteeg changed the title Add almaMmsId, dnbId, and zdbId to IdQuery Add almaMmsId, ~~dnbId, and~~ zdbId to IdQuery Oct 29, 2024
@fsteeg fsteeg changed the title Add almaMmsId, ~~dnbId, and~~ zdbId to IdQuery Add almaMmsId and zdbId to IdQuery Oct 29, 2024
fsteeg added a commit that referenced this issue Oct 29, 2024
@github-project-automation github-project-automation bot moved this from Backlog to Done in lobid-resources Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant