Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enrich isbn #1184

Merged
merged 2 commits into from
Apr 7, 2021
Merged

Enrich isbn #1184

merged 2 commits into from
Apr 7, 2021

Conversation

dr0i
Copy link
Member

@dr0i dr0i commented Apr 1, 2021

If an isbn10 exists a corresponding isbn13 is generated.
Also, an isbn is normalized by removing semnatic sugar, so that:

  • "isbn" : [ "3-642-32079-1" ],
  • "isbn" : [ "3642320791", "9783642320798" ],

See #1180.

If an isbn10 exists a corresponding isbn13 is generated.
Also, an isbn is normalized by removing semnatic sugar, so that:

-  "isbn" : [ "3-642-32079-1" ],
+  "isbn" : [ "3642320791", "9783642320798" ],

See #1180.
@dr0i dr0i requested a review from TobiasNx April 1, 2021 14:17
@dr0i dr0i added this to the almaMigration milestone Apr 1, 2021
I added a ISBN-10 Transformation and deleted the regex since the ISBN-function includes an conditional to check the length of an ISBN.
@TobiasNx
Copy link
Contributor

TobiasNx commented Apr 7, 2021

@hagbeck wanted both version of the ISBN I added a workflow to generate ISBN-10 if only ISBN-13 is available.

@TobiasNx TobiasNx assigned dr0i and unassigned TobiasNx Apr 7, 2021
Copy link
Contributor

@TobiasNx TobiasNx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added an ISBN-10 workflow.

Copy link
Member Author

@dr0i dr0i left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good improvement - thx!

@dr0i dr0i merged commit 17e0546 into master Apr 7, 2021
@dr0i dr0i deleted the 1180-enrichIsbn branch April 7, 2021 07:57
@dr0i
Copy link
Member Author

dr0i commented Apr 7, 2021

Deployed. Closed.

@dr0i dr0i mentioned this pull request Apr 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants