Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1917 por g sublibrary location #1918

Merged
merged 5 commits into from
Sep 29, 2023
Merged

1917 por g sublibrary location #1918

merged 5 commits into from
Sep 29, 2023

Conversation

TobiasNx
Copy link
Contributor

@TobiasNx TobiasNx commented Sep 29, 2023 •
edited
Loading

Related to #1917

This PR does four things:

  • add a testfile 990366624790206441
  • updates the local sublibrary / libraryCode map
  • adds a mapping for libraryCodes/sublibraries based on POR $g
  • introduces a macro for adding holdingLibraries and opac links that can be used for ITM, HOL + H52 and POR

blackwinter
blackwinter requested changes Sep 29, 2023
View reviewed changes
Copy link
Member

@blackwinter blackwinter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, that was quick :) Thank you very much!

However, this change doesn't seem to be covered by test examples (no new hasItem.seeAlso in d3ec19c). 990366624790206441 would be such an example.

@blackwinter blackwinter assigned TobiasNx and unassigned blackwinter Sep 29, 2023
@TobiasNx TobiasNx force-pushed the 1917-PorGSublibraryLocation branch from 80873de to 3e76368 Compare September 29, 2023 10:14
@TobiasNx
Copy link
Contributor Author

Now with updated libraryCode map and the suggested testfile.

@TobiasNx TobiasNx assigned blackwinter and unassigned TobiasNx Sep 29, 2023
blackwinter
blackwinter approved these changes Sep 29, 2023
View reviewed changes
Copy link
Member

@blackwinter blackwinter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@blackwinter blackwinter removed their assignment Sep 29, 2023
@dr0i dr0i merged commit ca6a0a7 into master Sep 29, 2023
1 check passed
@dr0i
Copy link
Member

dr0i commented Sep 29, 2023

Will be deployed next Monday.

@dr0i dr0i deleted the 1917-PorGSublibraryLocation branch September 29, 2023 12:49
@blackwinter blackwinter linked an issue Sep 29, 2023 that may be closed by this pull request
Map sublibraries/libraryCode for POR if POR $g exists #1917
Closed
@blackwinter blackwinter mentioned this pull request Sep 29, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blackwinter blackwinter blackwinter approved these changes

@dr0i dr0i Awaiting requested review from dr0i

Assignees

@dr0i dr0i

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Map sublibraries/libraryCode for POR if POR $g exists
3 participants
@TobiasNx @dr0i @blackwinter