Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename biblioVinoId to schoeneNummer (RPB-37) #1931

Merged
merged 1 commit into from
Nov 17, 2023
Merged

Conversation

fsteeg
Copy link
Member

@fsteeg fsteeg commented Oct 25, 2023

@fsteeg fsteeg requested a review from dr0i October 25, 2023 15:34
Copy link
Member

@dr0i dr0i left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are there no tests? I would expect some jsonld with the new field name (could be here https://github.com/hbz/rpb/).
Also, if you want to provide RDF the "schoeneNummer" needs to be defined in context.jsonld.

@dr0i dr0i assigned fsteeg and unassigned dr0i Oct 27, 2023
@fsteeg
Copy link
Member Author

fsteeg commented Nov 15, 2023

We're only reusing the index config from RPB, no data is indexed into a lobid-resources index. Test data in RPB is here: hbz/rpb@ff07a7c (was not in main when I openend this PR). RDF is not a use case here, and biblioVinoId (the old name) was not in the context either.

@fsteeg fsteeg assigned dr0i and unassigned fsteeg Nov 15, 2023
@dr0i
Copy link
Member

dr0i commented Nov 17, 2023

Can you explain why this is done in this lbid-resources repo and not in the rpb repo - the changes here don't have anything to do with lobid-resources IMO?

@dr0i dr0i assigned fsteeg and unassigned dr0i Nov 17, 2023
@fsteeg
Copy link
Member Author

fsteeg commented Nov 17, 2023

Can you explain why this is done in this lbid-resources repo and not in the rpb repo

We originally indexed RPB titles into the lobid-resources index (and might still do that in the future), so we're using the lobid-resources index-config.json. Also RPB uses a lobid-resources instance as its backend, hence the change in IdQuery. (And again, this is just the rename, this stuff is already in lobid-resources, see #1436 and #1460.)

@fsteeg fsteeg assigned dr0i and unassigned fsteeg Nov 17, 2023
@dr0i
Copy link
Member

dr0i commented Nov 17, 2023

OK, thx for explaining.

@dr0i dr0i assigned fsteeg and unassigned dr0i Nov 17, 2023
@fsteeg fsteeg merged commit 55af810 into master Nov 17, 2023
@fsteeg fsteeg deleted the rpb-37-schoeneNummer branch November 17, 2023 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants