Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Mapbox-based MakiMarkers with local default icon #1969

Merged
merged 4 commits into from
Feb 27, 2024
Merged

Conversation

fsteeg
Copy link
Member

@fsteeg fsteeg commented Feb 27, 2024

Will resolve #1966, see e.g. http://stage.lobid.org/resources/990182586200206441

(And two other tweaks for things I noticed.)

@fsteeg fsteeg requested a review from dr0i February 27, 2024 11:44
Copy link
Member

@dr0i dr0i left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code ok , but the marker cannot be loaded as only ./web/public/javascripts/images/marker-icon-2x.png exists but it wants ./web/public/javascripts/images/marker-icon.png .

@dr0i dr0i assigned fsteeg and unassigned dr0i Feb 27, 2024
@fsteeg
Copy link
Member Author

fsteeg commented Feb 27, 2024

That's weird, I actually had to rename the file since it wanted marker-icon-2x.png, not marker-icon.png. And I thought it was working when I deployed earlier. Will look into it.

@fsteeg
Copy link
Member Author

fsteeg commented Feb 27, 2024

Oh, I think I understand: my office screen is high-res, and I might have some scaling enabled on the OS level. So there, it requests the 2x version, so it worked when I tested and deployed it earlier. Now, on my home setup, I get the same error as you. Will add the other icon.

@fsteeg
Copy link
Member Author

fsteeg commented Feb 27, 2024

Deployed to test: http://test.lobid.org/resources/990182586200206441

(If you want, you could deploy to prod and stage if this is done and there is anything unusual to consider for deployment.)

@fsteeg fsteeg requested a review from dr0i February 27, 2024 14:57
@fsteeg fsteeg assigned dr0i and unassigned fsteeg Feb 27, 2024
@dr0i dr0i merged commit 94a8382 into master Feb 27, 2024
1 check passed
@fsteeg fsteeg mentioned this pull request Feb 27, 2024
@dr0i dr0i deleted the 1966-mapMarkers branch February 27, 2024 15:01
@dr0i dr0i restored the 1966-mapMarkers branch February 27, 2024 16:03
@dr0i dr0i deleted the 1966-mapMarkers branch February 27, 2024 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Map markers don't load
2 participants