Preserve order of suggestions search results (#2065) #2069
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use ordered list (`toList`), not unordered set (`toSet`)
|
@fsteeg I've readded the test instance , see also https://lobid.org/apihealth/ . You may want to review on test instance? |
|
Yes, thanks, looks good: https://test.lobid.org/resources/search?name=Hunsrücker+Heimatblätter&format=json:title Could you deploy to production and merge? |
|
Deployed to production, closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use ordered list (
toList), not unordered set (toSet).Will resolve #2065.
@dr0i: I wanted to deploy this to test for review, but https://test.lobid.org/resources is down, and there seems to be no monit process for it on our current test server (q3). Is this still missing from the move from q2 to q3? Or did you change something in the setup? This is a very small change, so maybe the best process in this case would be that you review it and then deploy it straight to production?