Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken zdbId #2093 #2094

Merged
merged 4 commits into from
Nov 7, 2024
Merged

Fix broken zdbId #2093 #2094

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4153cf7
Add testfile 99370673692206441 #2093
TobiasNx Nov 6, 2024
b061787
Adjust the regex for fixing zdbId #2093
TobiasNx Nov 6, 2024
306edb9
Adjust webapp tests #2093
TobiasNx Nov 6, 2024
964b921
Merge remote-tracking branch 'origin/2082-LookupGnd2Formangabe' into …
TobiasNx Nov 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/main/resources/alma/fix/identifiers.fix
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,7 +146,7 @@ end
# clean up ZDB
replace_all("zdbId", "\\(DE-600\\)","")
replace_all("zdbId", "\\(DE-599\\)ZDB","")
replace_all("zdbId", " ","-") # CZ entries have incorrect spaces sometimes in the zdbId, we need to replace them with "-".
replace_all("zdbId", "(\\d{1,7})-* ?-*([Xx\\d])","$1-$2") # CZ entries have incorrect whitespaces sometimes in the zdbId, we need to adjust them so only one "-" separates the first group of numbers from the last number.


copy_field("almaMmsId","rpbId")
Expand Down
Loading
Loading